On 31/03/17 12:05, Mauro Carvalho Chehab wrote: > Em Fri, 31 Mar 2017 10:58:39 +0200 > Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: > >> The V4L2_INPUT_TYPE_CAMERA and V4L2_OUTPUT_TYPE_ANALOG descriptions were >> hopelessly out of date. Fix this, and also fix a few style issues in these >> documents. Finally add the missing documentation for V4L2_OUTPUT_TYPE_ANALOGVGAOVERLAY >> (only used by the zoran driver). >> >> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> >> --- > > Patch looks OK to me, but see below. > >> Question: should we perhaps add _TYPE_VIDEO aliases? > > IMHO, let's rename it to _TYPE_VIDEO (or STREAM, or V_STREAM), and make > _TYPE_CAMERA an alias, e. g.: > > #define V4L2_INPUT_TYPE_VIDEO 2 > > #define V4L2_INPUT_TYPE_CAMERA V4L2_INPUT_TYPE_VIDEO > > This way, we'll let clearer what's currently preferred. We should also > change it at the documentation, mentioning that V4L2_INPUT_TYPE_CAMERA > is an alias, due to historical reasons. Does this really make sense to do this now? Everyone is used to the old defines, wouldn't changing this just increase confusion? Sorry, playing devil's advocate here. I'm a bit hesitant of doing this. We've done this in the past for APIs that were very new or rarely used, but this is everywhere. I feel fixing the spec is sufficient. If more people think that adding this aliases is a good idea, then I can do that. Regards, Hans
