Re: [PATCH] vidioc-enumin/output.rst: improve documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Fri, 31 Mar 2017 10:58:39 +0200
Hans Verkuil <hverkuil@xxxxxxxxx> escreveu:

> The V4L2_INPUT_TYPE_CAMERA and V4L2_OUTPUT_TYPE_ANALOG descriptions were
> hopelessly out of date. Fix this, and also fix a few style issues in these
> documents. Finally add the missing documentation for V4L2_OUTPUT_TYPE_ANALOGVGAOVERLAY
> (only used by the zoran driver).
> 
> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> ---

Patch looks OK to me, but see below.

> Question: should we perhaps add _TYPE_VIDEO aliases?

IMHO, let's rename it to _TYPE_VIDEO (or STREAM, or V_STREAM), and make 
_TYPE_CAMERA an alias, e. g.:

#define V4L2_INPUT_TYPE_VIDEO 2

#define V4L2_INPUT_TYPE_CAMERA V4L2_INPUT_TYPE_VIDEO

This way, we'll let clearer what's currently preferred. We should also
change it at the documentation, mentioning that V4L2_INPUT_TYPE_CAMERA
is an alias, due to historical reasons.

Thanks,
Mauro



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux