Re: [PATCH v10 2/2] media: i2c: Add support for OV5647 sensor.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ramiro,

On Wed, Mar 15, 2017 at 04:45:16PM +0000, Ramiro Oliveira wrote:
> Hi Sakari
> 
> On 3/7/2017 10:45 AM, Sakari Ailus wrote:
> > Hi Ramiro,
> > 
> > On Mon, Mar 06, 2017 at 11:16:34AM +0000, Ramiro Oliveira wrote:
> > ...
> >> +static int __sensor_init(struct v4l2_subdev *sd)
> >> +{
> >> +	int ret;
> >> +	u8 resetval, rdval;
> >> +	struct i2c_client *client = v4l2_get_subdevdata(sd);
> >> +
> >> +	dev_dbg(&client->dev, "sensor init\n");
> > 
> > This looks like a debugging time leftover. Please remove.
> > 
> 
> Should I send a v11 with this change?

Please do; you can add my ack on that one.

> 
> > With that,
> > 
> > Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > 
> > ...
> > 

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@xxxxxx	XMPP: sailus@xxxxxxxxxxxxxx



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux