Hi! > > Ok, I got the camera sensor to work. No subdevices support, so I don't > > have focus (etc) working, but that's a start. I also had to remove > > video-bus-switch support; but I guess it will be easier to use > > video-multiplexer patches... > > > > I'll have patches over weekend. > > I briefly looked at what's there --- you do miss the video nodes for the > non-sensor sub-devices, and they also don't show up in the media graph, > right? Yes. > I guess they don't end up matching in the async list. How should they get to the async list? > I think we need to make the non-sensor sub-device support more generic; > it's not just the OMAP 3 ISP that needs it. I think we need to document > the property for the flash phandle as well; I can write one, or refresh > an existing one that I believe already exists. > > How about calling it either simply "flash" or "camera-flash"? Similarly > for lens: "lens" or "camera-lens". I have a vague feeling the "camera-" > prefix is somewhat redundant, so I'd just go for "flash" or "lens". Actually, I'd go for "flash" and "focus-coil". There may be other lens properties, such as zoom, mirror movement, lens identification, ... > At the very least the property names must be generic (not hardware > dependent) as this kind of functionality should be present in the > framework rather than in individual drivers. That'll be for later > though. Agreed, that would be nice. > Making the sub-device bus configuration a pointer should be in a separate > patch. It makes sense since the entire configuration is not valid for all > sub-devices attached to the ISP anymore. I think it originally was a > separate patch, but they probably have been merged at some point. I can't > find it right now anyway. I believe I can find the patch. But I'm not sure if I can port it to the fwnode infrastructure anytime soon... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
