Hi Laurent, On Thu, Dec 15, 2016 at 01:23:50PM +0200, Laurent Pinchart wrote: > > @@ -1596,7 +1604,6 @@ static void isp_unregister_entities(struct isp_device > > *isp) omap3isp_stat_unregister_entities(&isp->isp_af); > > omap3isp_stat_unregister_entities(&isp->isp_hist); > > > > - v4l2_device_unregister(&isp->v4l2_dev); > > This isn't correct. The v4l2_device instance should be unregistered here, to > make sure that the subdev nodes are unregistered too. And even if moving the > function call was correct, it should be done in a separate patch as it's > unrelated to $SUBJECT. I think I tried to fix another problem here we haven't considered before, which is that v4l2_device_unregister() also unregisters the entities through media_device_unregister_entity(). This will set the media device of the graph objects NULL. I'll see whether something could be done to that. -- Regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
