Hi Skarai, On 12/15/2016 04:57 AM, Laurent Pinchart wrote: > On Thursday 15 Dec 2016 13:45:25 Sakari Ailus wrote: >> Hi Laurent, >> >> On 12/15/16 13:42, Laurent Pinchart wrote: >>> You can split that part out. The devm_* removal is independent and could >>> be moved to the beginning of the series. >> >> Where do you release the memory in that case? In driver's remove(), i.e. >> this patch would simply move that code to isp_remove()? > > Yes, the kfree() calls would be in isp_remove(). The patch will then be > faithful to its $SUBJECT, and moving to a release() handler should be done in > a separate patch. > I have a patch that does that for you. I was playing with devm removal from omap3. You are welcome to just use it. This also includes regulator puts in proper places. I also included a patch that removes extra media_entity_cleanup() I will send those in a bit thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html