Hi Sakari,
Thank you for the patch.
On Friday 25 Nov 2016 15:55:42 Sakari Ailus wrote:
> There's a sanity check for the stream count remaining positive or zero on
> error path, but instead of performing the check on the traversed entity it
> is performed on the entity where traversal ends. Fix this.
>
> Fixes: commit 3801bc7d1b8d ("[media] media: Media Controller fix to not let
> stream_count go negative") Signed-off-by: Sakari Ailus
> <sakari.ailus@xxxxxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/media-entity.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
> index 58d9fa6..da46706 100644
> --- a/drivers/media/media-entity.c
> +++ b/drivers/media/media-entity.c
> @@ -484,7 +484,7 @@ __must_check int __media_entity_pipeline_start(struct
> media_entity *entity,
>
> while ((entity_err = media_entity_graph_walk_next(graph))) {
> /* don't let the stream_count go negative */
> - if (entity->stream_count > 0) {
> + if (entity_err->stream_count > 0) {
> entity_err->stream_count--;
> if (entity_err->stream_count == 0)
> entity_err->pipe = NULL;
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
