Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2009-10-04 at 11:31 +0300, Aleksandr V. Piskunov wrote:
> On Sat, Oct 03, 2009 at 11:44:20AM -0400, Andy Walls wrote:
> > Aleksandr and Jean,
> > 
> > Zdrastvoitye & Bonjour,
> > 
> > To support the AVerMedia M166's IR microcontroller in ivtv and
> > ir-kbd-i2c with the new i2c binding model, I have added 3 changesets in
> > 
> > 	http://linuxtv.org/hg/~awalls/ivtv
> > 
> > 01/03: ivtv: Defer legacy I2C IR probing until after setup of known I2C devices
> > http://linuxtv.org/hg/~awalls/ivtv?cmd=changeset;node=3d243437f046
> > 
> > 02/03: ivtv: Add explicit IR controller initialization for the AVerTV M116
> > http://linuxtv.org/hg/~awalls/ivtv?cmd=changeset;node=0127ed2ea55b
> > 
> > 03/03: ir-kbd-i2c: Add support for the AVerTV M116 with the new binding model
> > http://linuxtv.org/hg/~awalls/ivtv?cmd=changeset;node=c10e0d5d895c
> > 
> > 
> > I cannot really test them as I still am using an older kernel.  Could
> > you please review, and test them if possible?
> > 
> 
> Thank you, Andy! Much more elegant solution than simply pounding 0x40 on every ivtv
> board.

Thank you.  Of course as Jean has pointed out, I have some things to
clean up.

> Tested on 2.6.30.8, one of Ubuntu mainline kernel builds.

Thank you for testing.

> ivtv-i2c part works, ivtv_i2c_new_ir() gets called, according to /sys/bus/i2c
> device @ 0x40 gets a name ir_rx_em78p153s_ave.
> 
> Now according to my (very) limited understanding of new binding model, ir-kbd-i2c
> should attach to this device by its name. Somehow it doesn't, ir-kbd-i2c gets loaded
> silently without doing anything.

As you probably know, the truncated name cannot be matched.


Regards,
Andy

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux