On Sun, 2009-10-04 at 12:26 +0300, Aleksandr V. Piskunov wrote:
> On Sun, Oct 04, 2009 at 10:44:52AM +0200, Jean Delvare wrote:
> > On Sun, 4 Oct 2009 11:31:39 +0300, Aleksandr V. Piskunov wrote:
> > > Tested on 2.6.30.8, one of Ubuntu mainline kernel builds.
> > >
> > > ivtv-i2c part works, ivtv_i2c_new_ir() gets called, according to /sys/bus/i2c
> > > device @ 0x40 gets a name ir_rx_em78p153s_ave.
> > >
> > > Now according to my (very) limited understanding of new binding model, ir-kbd-i2c
> > > should attach to this device by its name. Somehow it doesn't, ir-kbd-i2c gets loaded
> > > silently without doing anything.
> >
> > Change the device name to a shorter string (e.g. "ir_rx_em78p153s").
> > You're hitting the i2c client name length limit. More details about
> > this in the details reply I'm writing right now.
>
> Thanks, it works now. ir-kbd-i2c picks up the short name, input device is created, remote
> works.
>
> Another place where truncation occurs is name field in em78p153s_aver_ir_init_data
> ("ivtv-CX23416 EM78P153S AVerMedia"). Actual input device ends up with a name
> "i2c IR (ivtv-CX23416 EM78P153S ", limited by char name[32] in IR_i2c struct.
I'm naive here. What applications actually show this string or use it?
For what purposes do applications use it?
> IMHO actual name of resulting input device should be readable by end-user. Perhaps it should
> include the short name of the card itself, or model/color of remote control itself if several
> revisions exist, etc.
The em28xx driver uses things like:
i2c IR (EM28XX Terratec)
i2c IR (EM28XX Pinnacle PCTV)
The saa7134 driver uses thing like:
Pinnacle PCTV
Purple TV
MSI TV@nywhere Plus
HVR 1110
BeholdTV
The cx18 driver (i.e. me) uses:
CX23418 Z8F0811 Hauppauge
I appear to be user-unfriendly. ;) I guess I like knowing what devices
are precisely involved, as it helps me when I need to troubleshoot. I
agree that it doesn't help the normal user in day to day operations.
I will change the names to something more card specific. It could end
up slightly misleading in the long run. A single card entry in
ivtv-cards.c can describe multiple card variants, but gives all those
variants the same "name" whether or not the consumer retail names are
the same.
Regards,
Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
