Re: [PATCH v2 54/58] i2c: don't break long lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mauro,

Thanks for the patch.


On Tue, Oct 18, 2016 at 9:46 PM, Mauro Carvalho Chehab
<mchehab@xxxxxxxxxxxxxxxx> wrote:
> Due to the 80-cols restrictions, and latter due to checkpatch
> warnings, several strings were broken into multiple lines. This
> is not considered a good practice anymore, as it makes harder
> to grep for strings at the source code.
>
> As we're right now fixing other drivers due to KERN_CONT, we need
> to be able to identify what printk strings don't end with a "\n".
> It is a way easier to detect those if we don't break long lines.
>
> So, join those continuation lines.
>
> The patch was generated via the script below, and manually
> adjusted if needed.
>
> </script>
> use Text::Tabs;
> while (<>) {
>         if ($next ne "") {
>                 $c=$_;
>                 if ($c =~ /^\s+\"(.*)/) {
>                         $c2=$1;
>                         $next =~ s/\"\n$//;
>                         $n = expand($next);
>                         $funpos = index($n, '(');
>                         $pos = index($c2, '",');
>                         if ($funpos && $pos > 0) {
>                                 $s1 = substr $c2, 0, $pos + 2;
>                                 $s2 = ' ' x ($funpos + 1) . substr $c2, $pos + 2;
>                                 $s2 =~ s/^\s+//;
>
>                                 $s2 = ' ' x ($funpos + 1) . $s2 if ($s2 ne "");
>
>                                 print unexpand("$next$s1\n");
>                                 print unexpand("$s2\n") if ($s2 ne "");
>                         } else {
>                                 print "$next$c2\n";
>                         }
>                         $next="";
>                         next;
>                 } else {
>                         print $next;
>                 }
>                 $next="";
>         } else {
>                 if (m/\"$/) {
>                         if (!m/\\n\"$/) {
>                                 $next=$_;
>                                 next;
>                         }
>                 }
>         }
>         print $_;
> }
> </script>
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>

Acked-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>

Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux