Hi Mauro,
thanks a lot for your tests and inspirations ...
Am 22.09.2016 um 14:35 schrieb Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>:
> Hi Markus,
>
> Em Thu, 22 Sep 2016 09:08:50 -0300
> Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> escreveu:
>
>> Em Tue, 20 Sep 2016 20:56:35 +0200
>> Markus Heiser <markus.heiser@xxxxxxxxxxx> escreveu:
>>
>
>> The new parser seems to have some bugs, like those:
>>
>> $ kernel-lintdoc include/media/v4l2-ctrls.h
>> include/media/v4l2-ctrls.h:106 :WARN: typedef of function pointer not marked as typdef, use: 'typedef v4l2_ctrl_notify_fnc' in the comment.
>> ...
>> include/media/v4l2-ctrls.h:605 :WARN: typedef of function pointer not marked as typdef, use: 'typedef v4l2_ctrl_filter' in the comment.
>> ...
>> include/media/v4l2-ctrls.h:809 [kernel-doc WARN] : can't understand function proto: 'const char * const *v4l2_ctrl_get_menu(u32 id);'
>> ...
>
> I ran the kernel-lintdoc with:
> for i in $(git grep kernel-doc Documentation/media/kapi/|cut -d: -f4); do kernel-lintdoc --sloppy $i; done
>
> and I have a few comments:
>
> 1) instead of printing the full patch, it would be good to print the
> relative patch, as this makes easier to paste the errors on e-mails
> and on patches.
relative patch? ... I think you mean relative path, if so:
I can add an option like "--abspath", not a big deal
but whats about calling the lint with $(pwd)/$i ::
for i in $(git grep kernel-doc Documentation/media/kapi/|cut -d: -f4); do kernel-lintdoc --sloppy $(pwd)/$i; done
.. fits this solution to your use-case?
> 2) Parsing of embedded structs/unions
>
> On some headers like dvb_frontend.h, we have unamed structs and enums
> inside structs:
>
> struct dtv_frontend_properties {
> ...
> struct {
> u8 segment_count;
> enum fe_code_rate fec;
> enum fe_modulation modulation;
> u8 interleaving;
> } layer[3];
> ...
> };
>
> The fields of the embedded struct are described as:
>
> * @layer: ISDB per-layer data (only ISDB standard)
> * @layer.segment_count: Segment Count;
> * @layer.fec: per layer code rate;
> * @layer.modulation: per layer modulation;
> * @layer.interleaving: per layer interleaving.
>
> kernel-lintdoc didn't like that:
>
> drivers/media/dvb-core/dvb_frontend.h:513 :ERROR: duplicate parameter definition 'layer'
> drivers/media/dvb-core/dvb_frontend.h:514 :ERROR: duplicate parameter definition 'layer'
> drivers/media/dvb-core/dvb_frontend.h:515 :ERROR: duplicate parameter definition 'layer'
> drivers/media/dvb-core/dvb_frontend.h:516 :ERROR: duplicate parameter definition 'layer'
Hah .. fixed this yesterday ;-)
https://github.com/return42/linuxdoc/commit/531df6dd7728393f447b1a4b3215b96687d02ba2
I analyzed this yesterday and haven't had time to report it,
so I will do it now:
This is also broken in the kernel-doc (perl) parser
.. are you able to fix it?
I can give it I try, but I have no extensive test case for the
perl version and perl is a bid harder for me. So sometimes I'am
a bit scary about patching the kernel-doc perl script.
(as I said before, for the py version I test against the
whole source and compare/versionize the resulted reST)
What I tested:
./scripts/kernel-doc -rst -function dtv_frontend_properties drivers/media/dvb-core/dvb_frontend.h
for "layer" it outputs:
``layer[3]``
per layer interleaving.
Read my commit message above .. the description block is taken
from " @layer.interleaving:" instead from "@layer:".
> 2) it complains about function typedefs:
>
> drivers/media/dvb-core/demux.h:251 :WARN: typedef of function pointer not marked as typdef, use: 'typedef dmx_ts_cb' in the comment.
> drivers/media/dvb-core/demux.h:292 :WARN: typedef of function pointer not marked as typdef, use: 'typedef dmx_section_cb' in the comment.
> include/media/v4l2-ioctl.h:677 :WARN: typedef of function pointer not marked as typdef, use: 'typedef v4l2_kioctl' in the comment.
> include/media/v4l2-ctrls.h:106 :WARN: typedef of function pointer not marked as typdef, use: 'typedef v4l2_ctrl_notify_fnc' in the comment.
> include/media/v4l2-ctrls.h:606 :WARN: typedef of function pointer not marked as typdef, use: 'typedef v4l2_ctrl_filter' in the comment.
> include/media/v4l2-dv-timings.h:39 :WARN: typedef of function pointer not marked as typdef, use: 'typedef v4l2_check_dv_timings_fnc' in the comment.
> include/media/v4l2-dv-timings.h:39 :WARN: typedef of function pointer used uncommon code style: 'typedef bool v4l2_check_dv_timings_fnc(const struct v4l2_dv_timings *t, void *handle);'
> include/media/videobuf2-core.h:877 :WARN: typedef of function pointer not marked as typdef, use: 'typedef vb2_thread_fnc' in the comment.
Thanks for reporting this ... fixed it:
https://github.com/return42/linuxdoc/commit/9228f2128dba967519fd8f2cdeb2c2202caad84d
> 3) this is actually a more complex problem: how to represent returned values
> from the function callbacks. Maybe we'll need to patch kernel-doc. Right now,
> it complains with:
>
> drivers/media/dvb-core/demux.h:397 :WARN: duplicate section name 'It returns'
> drivers/media/dvb-core/demux.h:415 :WARN: duplicate section name 'It returns'
> drivers/media/dvb-core/demux.h:431 :WARN: duplicate section name 'It returns'
> drivers/media/dvb-core/demux.h:444 :WARN: duplicate section name 'It returns'
> drivers/media/dvb-core/demux.h:462 :WARN: duplicate section name 'It returns'
> drivers/media/dvb-core/demux.h:475 :WARN: duplicate section name 'It returns'
> drivers/media/dvb-core/demux.h:491 :WARN: duplicate section name 'It returns'
> drivers/media/dvb-core/demux.h:507 :WARN: duplicate section name 'It returns'
> drivers/media/dvb-core/demux.h:534 :WARN: duplicate section name 'It returns'
> drivers/media/dvb-core/demux.h:542 :WARN: duplicate section name 'It returns'
> drivers/media/dvb-core/demux.h:552 :WARN: duplicate section name 'It returns'
Hmm, IMO we should keep the kernel-doc markup simple.
Sub-sections in parameter descriptions are not provided
and we should not change this.
This in mind, the above WARN messages are inappropriate.
I fixed the parser.
https://github.com/return42/linuxdoc/commit/6b664f537adc7970baffc8dae1ecf97c601ac7f9
> 4) Parse errors.
>
> Those seem to be caused by some errors at the parser:
>
> include/media/v4l2-ctrls.h:809 :WARN: can't understand function proto: 'const char * const *v4l2_ctrl_get_menu(u32 id);'
Argh, there was a type in the regexpr / fixed:
https://github.com/return42/linuxdoc/commit/dcf91bb2220c64135a2da7df866d06c126fb103e
> include/media/v4l2-dev.h:173 :WARN: no description found for parameter 'valid_ioctls\[BITS_TO_LONGS(BASE_VIDIOC_PRIVATE)\]'
> include/media/v4l2-dev.h:173 :WARN: no description found for parameter 'disable_locking\[BITS_TO_LONGS(BASE_VIDIOC_PRIVATE)\]'
> include/media/videobuf2-core.h:555 :ERROR: can't parse struct!
>
Argh, another typo .. fixed:
https://github.com/return42/linuxdoc/commit/2947952d3fce17367193a3511349312f7a75ff04
BTW: I fixed some more issues (see last changelogs).
FYI: if you made a pip install, then update with:
pip install --upgrade git+http://github.com/return42/linuxdoc.git
Ok let me say again, thanks for reporting all this, if you find more
please inform me.
Now I'am to tired, but I hope tomorrow I have the time to think
about your last mail: using lint in conf_nitpick.py
-- Markus --
>
> Thanks,
> Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
