Re: [PATCH 2/2] em28xx: Convert printks to em28xx_err and em28xx_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 28, 2009 at 12:19 PM, Filipe Rosset <rosset.filipe@xxxxxxxxx> wrote:
> Em 28-09-2009 12:24, Devin Heitmueller escreveu:
>> On Mon, Sep 28, 2009 at 11:03 AM, Filipe Rosset <rosset.filipe@xxxxxxxxx> wrote:
>>>
>>
>> You should use the em28xx_errdev() instead of em28xx_err() if your
>> intent is to insert "dev->name" in front of the message.
>>
>> Devin
>>
>
> OK, modified patch.
>
> Filipe
>

Filipe,

Your updated patch is going to effectively print dev->name twice.
Please look at the definition of em28xx_errdev() and resubmit an
updated patch that takes this into account.

Thanks,

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux