Re: [PATCH] [media] rcar-fcp: Make sure rcar_fcp_enable() returns 0 on success

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

On Mon, Sep 5, 2016 at 10:25 AM, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> On Monday 05 Sep 2016 10:20:52 Geert Uytterhoeven wrote:
>> On Mon, Sep 5, 2016 at 10:17 AM, Laurent Pinchart wrote:
>> >> BTW, it seems I missed a few more s2ram resume errors:
>> >>     dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns -13
>> >>     PM: Device fe920000.vsp failed to resume noirq: error -13
>> >>     dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns -13
>> >>     PM: Device fe960000.vsp failed to resume noirq: error -13
>> >>     dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns -13
>> >>     PM: Device fe9a0000.vsp failed to resume noirq: error -13
>> >>     dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns -13
>> >>     PM: Device fe9b0000.vsp failed to resume noirq: error -13
>> >>     dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns -13
>> >>     PM: Device fe9c0000.vsp failed to resume noirq: error -13
>> >>     dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns -13
>> >>     PM: Device fea20000.vsp failed to resume noirq: error -13
>> >>     dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns -13
>> >>     PM: Device fea28000.vsp failed to resume noirq: error -13
>> >>     dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns -13
>> >>     PM: Device fea30000.vsp failed to resume noirq: error -13
>> >>     vsp1 fea38000.vsp: failed to reset wpf.0
>> >>     dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns -110
>> >>     PM: Device fea38000.vsp failed to resume noirq: error -110
>> >>
>> >> -13 == -EACCES, returned by rcar_fcp_enable() as pm_runtime_get_sync()
>> >> is called too early during system resume,
>> >
>> > Do you have a fix for this ? :-)
>>
>> Unfortuately not.
>
> Is this caused by the fact that pm_runtime_get_sync() is called on the FCP
> device before the FCP gets system-resumed ? Lovely PM order dependency :-/

It's called from resume_noirq. IIRC, it's called a second time from resume.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux