Am Dienstag, den 22.09.2009, 05:31 +0200 schrieb Markus Rechberger:
> On Tue, Sep 22, 2009 at 4:00 AM, hermann pitton <hermann-pitton@xxxxxxxx> wrote:
> > Hi Markus,
> >
> > Am Montag, den 21.09.2009, 12:02 +0200 schrieb Markus Rechberger:
> >> ----
> >> in dvb-frontend.c:
> >> ----
> >> if(cmd == FE_GET_PROPERTY) {
> >>
> >> tvps = (struct dtv_properties __user *)parg;
> >> dprintk("%s() properties.num = %d\n", __func__, tvps->num);
> >> dprintk("%s() properties.props = %p\n", __func__, tvps->props);
> >> ...
> >> if (copy_from_user(tvp, tvps->props, tvps->num *
> >> sizeof(struct dtv_property)))
> >> ----
> >>
> >>
> >> > OK,
> >> >
> >> > thought I'll have never to care for it again.
> >> >
> >> > ENUM calls should never be W.
> >> >
> >> > Hit me for all I missed.
> >> >
> >> > Cheers,
> >> > Hermann
> >>
> >> you are not seeing the point of it it seems
> >
> > you are right, I do not see your point at all, but I was wrong for the
> > get calls.
> >
> > We had such discussions on v4l ioctls previously.
> >
> > The result was to keep them as is and not to change IOR to IOWR to keep
> > compatibility.
> >
> > This is six years back.
> >
>
> I think they all have got fixed up for v4l2 back then
>
> #ifdef __OLD_VIDIOC_
> /* for compatibility, will go away some day */
> #define VIDIOC_OVERLAY_OLD _IOWR('V', 14, int)
> #define VIDIOC_S_PARM_OLD _IOW('V', 22, struct v4l2_streamparm)
> #define VIDIOC_S_CTRL_OLD _IOW('V', 28, struct v4l2_control)
> #define VIDIOC_G_AUDIO_OLD _IOWR('V', 33, struct v4l2_audio)
> #define VIDIOC_G_AUDOUT_OLD _IOWR('V', 49, struct v4l2_audioout)
> #define VIDIOC_CROPCAP_OLD _IOR('V', 58, struct v4l2_cropcap)
> #endif
>
> to eg:
> #define VIDIOC_OVERLAY _IOW('V', 14, int)
> #define VIDIOC_S_PARM _IOWR('V', 22, struct v4l2_streamparm)
> #define VIDIOC_S_CTRL _IOWR('V', 28, struct v4l2_control)
> #define VIDIOC_G_AUDIO _IOR('V', 33, struct v4l2_audio)
> #define VIDIOC_G_AUDOUT _IOR('V', 49, struct v4l2_audioout)
> #define VIDIOC_CROPCAP _IOWR('V', 58, struct v4l2_cropcap)
>
> so only the DVB-API remains bugged now.
>
> Markus
All fine.
But you do cut off parts of my messages.
I would like to ask you to exercise a breakage, not only for stuff six
years back, but on recent S2 API.
Likely you get some more interested into it then.
Cheers,
Hermann
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
