Dne Po 14. září 2009 23:21:33 Guennadi Liakhovetski napsal(a): > On Mon, 14 Sep 2009, Marek Vasut wrote: > > Dne Po 14. září 2009 22:30:41 Guennadi Liakhovetski napsal(a): > > > On Mon, 14 Sep 2009, Marek Vasut wrote: > > > > Dne Po 14. září 2009 21:29:26 Guennadi Liakhovetski napsal(a): > > > > > From: Marek Vasut <marek.vasut@xxxxxxxxx> > > > > > > > > > > Signed-off-by: Marek Vasut <marek.vasut@xxxxxxxxx> > > > > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > > > > > --- > > > > > > > > > > Marek, please confirm, that this version is ok. I'll push it > > > > > upstream for 2.6.32 then. > > > > > > > > No, it's not OK. You removed the RGB part. Either enclose those parts > > > > into ifdef OV9640_RGB_BUGGY or preserve it in some other way. Someone > > > > will certainly want to re-add RGB parts later and will have to figure > > > > it out all over again. > > > > > > Ok, make a proposal, how you would like to see it. But - I do not want > > > commented out code, including "#ifdef MACRO_THAT_DOESNT_GET_DEFINED." I > > > think, I described it in sufficient detail, so that re-adding that code > > > should not take longer than 10 minutes for anyone sufficiently familiar > > > with the code. Referencing another driver also has an advantage, that > > > if we switch to imagebus or any other API, you don't get stale > > > commented out code, but you look up updated code in a functional > > > driver. But I am open to your ideas / but no commented out code, > > > please. > > > > The RGB is broken only in a way where it swaps colours, the color matrix > > coeficients and register configurations are OK (which is what other > > people who will want to add it will need to figure out again from scratch > > if you remove the code). > > Excuse me, have you looked at my patch? Have you compared it to yours? I > only removed your RGB code entries from the list of supported formats, I > haven't removed any implementation details, thus effectively just > disabling it. Just briefly skimmed over it. Ok then, that diff seems fine. I assume the imagebus will fix the rgb issues anyway. > > > I dont want this merged before this is solved in some way where those > > values are preserved. > > Sure, let's have it fixed and submit it in time for 2.6.33. > > Thanks > Guennadi > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Software Developer > http://www.open-technology.de/ > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
