Re: [linuxtv-commits] [hg:v4l-dvb] cx25840: fix determining the firmware name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Mon, 7 Sep 2009 10:44:11 +0300
Konstantin Dimitrov <kosio.dimitrov@xxxxxxxxx> escreveu:

> On Mon, Sep 7, 2009 at 9:06 AM, Mauro Carvalho
> Chehab<mchehab@xxxxxxxxxxxxx> wrote:
> > Em Mon, 7 Sep 2009 01:20:33 -0400
> > Michael Krufky <mkrufky@xxxxxxxxxxxxxx> escreveu:
> >
> >> On Mon, Sep 7, 2009 at 1:10 AM, Mauro Carvalho
> >> Chehab<mchehab@xxxxxxxxxxxxx> wrote:
> >> > Em Fri, 4 Sep 2009 14:05:31 -0400
> >> > Michael Krufky <mkrufky@xxxxxxxxxxxxxx> escreveu:
> >> >
> >> >> Mauro,
> >> >>
> >> >> This fix should really go to Linus before 2.6.31 is released, if
> >> >> possible.  It also should be backported to stable, but I need it in
> >> >> Linus' tree before it will be accepted into -stable.
> >> >>
> >> >> Do you think you can slip this in before the weekend?  As I
> >> >> understand, Linus plans to release 2.6.31 on Saturday, September 5th.
> >> >>
> >> >> If you dont have time for it, please let me know and I will send it in myself.
> >> >>
> >> >
> >> > This patch doesn't apply upstream:
> >> >
> >> > $ patch -p1 -i 12613.patch
> >> > patching file drivers/media/video/cx25840/cx25840-firmware.c
> >> > Hunk #5 FAILED at 107.
> >> > 1 out of 5 hunks FAILED -- saving rejects to file drivers/media/video/cx25840/cx25840-firmware.c.re
> >>
> >>
> >> OK, this is going to need a manual backport.  This does fix an issue
> >> in 2.6.31, and actually affects all kernels since the appearance of
> >> the cx23885 driver, but I can wait until you push it to Linus in the
> >> 2.6.32 merge window, then I'll backport & test it for -stable.
> >
> > Ok. I think I asked you once, but let me re-ask again: from what I was told, the
> > latest cx25840 firmware (the one that Conexant give us the distribution rights)
> > seems to be common to several cx25840-based chips. It would be really good if
> 
> i also noticed that 3 firmwares with different file names and used by
> different drivers:
> 
> - "v4l-cx23418-dig.fw" used by "cx18" driver, available here:
> http://dl.ivtvdriver.org/ivtv/firmware/cx18-firmware.tar.gz 

Conexant sent me in March a set of firmwares, that are available at both
firmware -git tree and at:
	http://linuxtv.org/downloads/firmware/

They sent it together with the distribution rights as stated at the README file.

However, the firmware versions have a different md5sum:

a9f8f5d901a7fb42f552e1ee6384f3bb  v4l-cx231xx-avcore-01.fw
a9f8f5d901a7fb42f552e1ee6384f3bb  v4l-cx23885-avcore-01.fw
a9f8f5d901a7fb42f552e1ee6384f3bb  v4l-cx23885-enc.fw

(the three above are the same firmware and are 3 different names supported at
cx23885 driver)

dadb79e9904fc8af96e8111d9cb59320  v4l-cx25840.fw

This one is different.

Maybe a better strategy would be to name the firmware by versions, since maybe
the differences are just the firmware version for each.

> and includes notice about distribution permission from Conexant too
> 
> - "v4l-cx23885-avcore-01.fw" used by "cx23885" driver
> 
> - "v4l-cx25840.fw" used by "cx25840" driver
> 
> have exactly the same md5sum: b3704908fd058485f3ef136941b2e513 and
> actually are the same firmware.

Yes. That's the point. So, a patch like this is incomplete  or useless due to
one of the reasons bellow:

1) the firmware doesn't work with some devices that could require a different version;

2) some earlier steppings of some chips require a different firmware;

3) Some of the firmwares supplied by the vendor are incorrect;

4) The new firmware works fine with all devices.

So, we need to test the firmware with md5sum: b3704908fd058485f3ef136941b2e513
with all device types to be sure and to provide the proper fix that could
require renaming some of those firmwares or just use one firmware name for all.

I remember I asked both Mikes (Michael Krufky and Mike Isely) on March for some
tests with the new firmware. I'm not sure if they had some time for testing it.

It would be interesting the feedback also from the users to report if the
March, 2009 firmwares work with their devices and, if not, what firmwares work.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux