On Tue, Sep 1, 2009 at 3:43 PM, Janne Grunau<j@xxxxxxxxxx> wrote: > Mauro, > > Please pull from http://hg.jannau.net/v4l-dvb/v4l-dvb > > for the following 4 changesets: > > 01/04: hdpvr: i2c fixups for fully functional IR support > http://hg.jannau.net/v4l-dvb/v4l-dvb?cmd=changeset;node=24f996ba510e > > 02/04: DVB: make DVB_MAX_ADAPTERS configureable > http://hg.jannau.net/v4l-dvb/v4l-dvb?cmd=changeset;node=49cecb27a086 > > 03/04: dvb-core: check fe->ops.set_frontend return value > http://hg.jannau.net/v4l-dvb/v4l-dvb?cmd=changeset;node=4938eaa8ee76 > > 04/04: dvb-core: check supported QAM modulations > http://hg.jannau.net/v4l-dvb/v4l-dvb?cmd=changeset;node=b746ea1289a0 > > > dvb/Kconfig | 13 +++++++++++++ > dvb/dvb-core/dvb_frontend.c | 35 ++++++++++++++++++++++++++++++----- > dvb/dvb-core/dvbdev.h | 5 +++++ > video/hdpvr/Makefile | 4 +--- > video/hdpvr/hdpvr-core.c | 6 +++--- > video/hdpvr/hdpvr-i2c.c | 5 ++++- > 6 files changed, 56 insertions(+), 12 deletions(-) > > Thanks, > Janne > Janne, This is great -- I only see one issue here, but it should not prevent any merge. Please submit an additional patch to correct the misspelled word "vallues" to "values" in the "DVB: make DVB_MAX_ADAPTERS configureable" patch. Actually, another spelling error -- "configureable" should actually be spelled as, "configurable" Many people will be excited to have the i2c functionality working in the HD-PVR -- it will be great to have i2c receive and transmit working in conjunction with the lirc_zilog module. The frontend error checking patch will be a great addition. The QAM modulation check looks good to me too, but I am not as familiar with the DVB-C support as I am with DVB-T and ATSC. Looks safe for merge to my eyes. Please merge these, Mauro :-) Reviewed-by: Michael Krufky <mkrufky@xxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
