Hi Steven, As I'm understanding that you're reveiwing it, I'm marking this patch as such at Patchwork. Cheers, Mauro. Em Thu, 20 Aug 2009 18:38:46 +0300 Konstantin Dimitrov <kosio.dimitrov@xxxxxxxxx> escreveu: > On Thu, Aug 20, 2009 at 4:03 PM, Steven Toth<stoth@xxxxxxxxxxxxxx> wrote: > > On 8/19/09 7:20 PM, Konstantin Dimitrov wrote: > >> > >> fix: GPIO initialization for TBS 6920 > >> fix: wrong I2C address for demod on TBS 6920 > >> fix: wrong I2C bus number for demod on TBS 6920 > >> fix: wrong "gen_ctrl_val" value for TS1 port on TBS 6920 (and some other > >> cards) > >> add: module_param "lnb_pwr_ctrl" as option to choose between "type 0" and > >> "type 1" of LNB power control (two TBS 6920 boards no matter that they are > >> marked as the same hardware revision may have different types of LNB power > >> control) > >> fix: LNB power control function for type 0 doesn't preserve the previous > >> GPIO state, which is critical > >> add: LNB power control function for type 1 > >> > >> Signed-off-by: Bob Liu<bob@xxxxxxxxxxxxxx> > >> Signed-off-by: Konstantin Dimitrov<kosio.dimitrov@xxxxxxxxx> > > Hmm. A custom hanging off of a gpio to something that looks like an i2c > > power control device. I want to review some of these generic (and > > no-so-generic) changes before we merge this patch. > > > > Is the datasheet for the LNB power control device available to the public? > > I'd like to understand some of the register details. > > the datasheet is not available at least to me and i don't know any > more details. the code in question was given to me by the author under > GPLv2 license and that's why i put it in separate file > "tbs_lnb_pwr.c". > > also, the cards that use this type of LNB power control, which i > called for short "type 1", have the same device IDs as the one that > don't use it and use "type 0" of LNB power control instead. > > --konstantin > > > > > Thanks, > > > > -- > > Steven Toth - Kernel Labs > > http://www.kernellabs.com > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-media" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
