Em Tue, 11 Aug 2009 12:29:36 +0200 Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> escreveu: > On Monday 10 August 2009 19:37:40 Tuukka.O Toivonen wrote: > > When user space queues a buffer using VIDIOC_QBUF, the kernel > > should set flags to V4L2_BUF_FLAG_QUEUED in struct v4l2_buffer. > > videobuf_qbuf() was missing a call to videobuf_status() which does > > that. This patch adds the proper function call. > > > > Signed-off-by: Tuukka Toivonen <tuukka.o.toivonen@xxxxxxxxx> > > I was a bit surprised, as I didn't think VIDIOC_QBUF was supposed to update > the buffer structure, but according to the v4l2 spec it is. > > However, I don't think calling videobuf_status() is the right thing to do. It > will update fields that don't make sense at this point, such as > v4l2_buffer::timestamp. > > Thanks Tuukka for finding this, I'll update the UVC video driver > accordingly :-) Tuukka, Could you please update your patch to take Laurent's comments into consideration Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
