Re: [PATCH] Report only 32kHz for ALSA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Dienstag, den 18.08.2009, 21:24 +0200 schrieb Oldřich Jedlička:
> There are several reasons:
> 
>  - SAA7133/35 uses DDEP (DemDec Easy Programming mode), which works in 32kHz
>    only
>  - SAA7134 for TV mode uses DemDec mode (32kHz)
>  - Radio works in 32kHz only
>  - When recording 48kHz from Line1/Line2, switching of capture source to TV
>    means switching to 32kHz without any frequency translation
> 
> Signed-off-by: Oldřich Jedlička <oldium.pro@xxxxxxxxx>

As discussed previously, this is an improvement within our current chip
specific capabilities. Thanks.

Acked-by: hermann pitton <hermann-pitton@xxxxxxxx>

> diff --git a/linux/drivers/media/video/saa7134/saa7134-alsa.c b/linux/drivers/media/video/saa7134/saa7134-alsa.c
> index c09ec3e..504186a 100644
> --- a/linux/drivers/media/video/saa7134/saa7134-alsa.c
> +++ b/linux/drivers/media/video/saa7134/saa7134-alsa.c
> @@ -440,6 +440,16 @@ snd_card_saa7134_capture_pointer(struct snd_pcm_substream * substream)
>  
>  /*
>   * ALSA hardware capabilities definition
> + *
> + *  Report only 32kHz for ALSA:
> + *
> + *  - SAA7133/35 uses DDEP (DemDec Easy Programming mode), which works in 32kHz
> + *    only
> + *  - SAA7134 for TV mode uses DemDec mode (32kHz)
> + *  - Radio works in 32kHz only
> + *  - When recording 48kHz from Line1/Line2, switching of capture source to TV
> + *    means
> + *    switching to 32kHz without any frequency translation
>   */
>  
>  static struct snd_pcm_hardware snd_card_saa7134_capture =
> @@ -453,9 +463,9 @@ static struct snd_pcm_hardware snd_card_saa7134_capture =
>  				SNDRV_PCM_FMTBIT_U8 | \
>  				SNDRV_PCM_FMTBIT_U16_LE | \
>  				SNDRV_PCM_FMTBIT_U16_BE,
> -	.rates =		SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_48000,
> +	.rates =		SNDRV_PCM_RATE_32000,
>  	.rate_min =		32000,
> -	.rate_max =		48000,
> +	.rate_max =		32000,
>  	.channels_min =		1,
>  	.channels_max =		2,
>  	.buffer_bytes_max =	(256*1024),
> --


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux