> shouldn't there be a check when allocating jpg_hdr? or i am missing something? > > > sd->jpeg_hdr = kmalloc(JPEG_HDR_SZ, GFP_KERNEL); > jpeg_define(sd->jpeg_hdr, height, width, 0x21); > jpeg_set_qual(sd->jpeg_hdr, sd->quality); Yes probably there should be a check there. I'll one more minor revision with this plus the changes Jean-Francois mentioned previously in a bit. Brian Johnson -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html