Hi, shouldn't there be a check when allocating jpg_hdr? or i am missing something? sd->jpeg_hdr = kmalloc(JPEG_HDR_SZ, GFP_KERNEL); jpeg_define(sd->jpeg_hdr, height, width, 0x21); jpeg_set_qual(sd->jpeg_hdr, sd->quality); Best Regards. Nice to see microdia project here :) On Sat, Jul 18, 2009 at 11:19 AM, Brian Johnson<brijohn@xxxxxxxxx> wrote: >> - in the 1st patch, in gspca.c, why is the get_chip_ident check needed >> in vidioc_g_register / vidioc_s_register)? >> > According the the current v4l2 spec regarding the set and get > register ioctls drivers that support them must also support the get > chip ident ioctl. As such in the vidioc_s/g_register ioctls I do the > check to ensure that the driver also defines the get_chip_ident ioctl. > > > Brian Johnson > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
