Re: lsmod path hardcoded in v4l/Makefile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2009-06-22 at 16:36 +0200, Matthias Schwarzott wrote:
> Hi list!
> 
> It seems the path to lsmod tool is hardcoded in the Makefile for out-of-tree 
> building of v4l-dvb.
> Now at least gentoo has moved lsmod from /sbin to /bin.
> Additionally it is bad style (or at least I am told so), to not rely on $PATH 
> but hardcode pathes for tools that should be in $PATH.

It's a potential security hole to rely on $PATH instead of absolute
paths when running a command as root.

Since many of the commnads in the Makefile rely on $PATH, including
executions of 'install' which usually would be run as root, I suppose
secuirty concerns don't matter.

-Andy

> So the attached patch removes the hardcoded /sbin from the lsmod call.
> 
> Signed-off-by: Matthias Schwarzott <zzam@xxxxxxxxxx>
> 
> Regards
> Matthias

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux