RE: [PATCH 3/11 - v3] dm355 ccdc module for vpfe capture driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> <snip>
>>
>> > +static int dm355_ccdc_init(void)
>> > +{
>> > +       printk(KERN_NOTICE "dm355_ccdc_init\n");
>> > +       if (vpfe_register_ccdc_device(&ccdc_hw_dev) < 0)
>> > +               return -1;
>>
>> Don't you want to rewrite this to return good error code?
>> int ret;
>> printk();
>> ret = vpfe_register_ccdc_device();
>> if (ret < 0)
>> return ret;
>>
>> I know you have tight/fast track/hard schedule, so you can do this
>> improvement later, after merging this patch.
>
>I haven't changed this or the similar comment in patch 4/11, but it is
>something that Muralidharan should look at and fix later.
>
>Regards,
>
>	Hans
[MK] I will take care of this through a separate patch

Murali
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux