Hello,
one more small comment
On Thu, Jun 18, 2009 at 12:11 AM, <m-karicheri2@xxxxxx> wrote:
> From: Muralidharan Karicheri <m-karicheri2@xxxxxx>
>
> DM355 CCDC hw module
>
> Adds ccdc hw module for DM355 CCDC. This registers with the bridge
> driver a set of hw_ops for configuring the CCDC for a specific
> decoder device connected to vpfe.
>
> The module description and owner information added
<snip>
> +static int dm355_ccdc_init(void)
> +{
> + printk(KERN_NOTICE "dm355_ccdc_init\n");
> + if (vpfe_register_ccdc_device(&ccdc_hw_dev) < 0)
> + return -1;
Don't you want to rewrite this to return good error code?
int ret;
printk();
ret = vpfe_register_ccdc_device();
if (ret < 0)
return ret;
I know you have tight/fast track/hard schedule, so you can do this
improvement later, after merging this patch.
> + printk(KERN_NOTICE "%s is registered with vpfe.\n",
> + ccdc_hw_dev.name);
> + return 0;
> +}
> +
> +static void dm355_ccdc_exit(void)
> +{
> + vpfe_unregister_ccdc_device(&ccdc_hw_dev);
> +}
--
Best regards, Klimov Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
