On Thu, Jun 18, 2009 at 12:11 AM, <m-karicheri2@xxxxxx> wrote:
> From: Muralidharan Karicheri <m-karicheri2@xxxxxx>
>
> DM644x CCDC hw module
>
> This is the hw module for DM644x CCDC. This registers with the
> vpfe capture driver and provides a set of hw_ops to configure
> CCDC for a specific decoder device connected to the VPFE
>
> Module description, GPL and owner information MACROs added at the top
<snip>
> +static int dm644x_ccdc_init(void)
> +{
> + printk(KERN_NOTICE "dm644x_ccdc_init\n");
> + if (vpfe_register_ccdc_device(&ccdc_hw_dev) < 0)
> + return -1;
The same small idea like in "[PATCH 3/11 - v3] dm355 ccdc module for
vpfe capture driver" about this function. What do you think about
introducing ret variable and returning good error code?
> + printk(KERN_NOTICE "%s is registered with vpfe.\n",
> + ccdc_hw_dev.name);
> + return 0;
> +}
> +
> +static void dm644x_ccdc_exit(void)
> +{
> + vpfe_unregister_ccdc_device(&ccdc_hw_dev);
> +}
--
Best regards, Klimov Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
