Re: [PATCHv7 2/9] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 16, 2009 at 01:18:57PM +0200, ext Hans Verkuil wrote:
> On Tuesday 16 June 2009 12:52:34 Eduardo Valentin wrote:
> > > It is my believe that the other fm_tx controls are unambiguously
> > > transmitter related, so I don't think they need a TX prefix. It doesn't
> > > hurt if someone can double check that, though.
> >
> > hmm.. I see no problem removing the fmtx prefix of the preemphasis
> > enum. But, if it is becoming a generic enum, better to check if its
> > meaning is the same of existing emphasis enum for mpeg.
> 
> It has the same meaning, but unfortunately the mpeg enum is already a public 
> API and so cannot be changed. I never realized at the time that that enum 
> is more generic than I thought.
> 
> But at least this enum can be made generic.

Yes, sure.

> 
> Regards,
> 
> 	Hans
> 
> -- 
> Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Eduardo Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux