= >dm644x_clear_wbl_overflow; >> + else >> + return -ENODEV; > >Do you need clean up procedure if you return error here? I mean - >calls to release_mem_region, release_mem_region, etc > Oops! I need to add that. Thanks. >> + spin_lock_init(&oper_cfg.vpss_lock); >> + dev_info(&pdev->dev, "%s vpss probe success\n", >oper_cfg.vpss_name); >> + return 0; >> +fail3: >> + release_mem_region(oper_cfg.r2->start, oper_cfg.len2); >> +fail2: >> + iounmap(oper_cfg.vpss_bl_regs_base); >> +fail1: >> + release_mem_region(oper_cfg.r1->start, oper_cfg.len1); >> + return status; >> +} > > >-- >Best regards, Klimov Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html