>> + /* set the default image parameters in the device */ >> + ret = vpfe_config_image_format(vpfe_dev, >> + &vpfe_standards[vpfe_dev- >>std_index].std_id); >> + if (ret) >> + goto unlock_out; > >Why you check ret value and go to label below? >Probably you can remove if-check and goto here. > Ok. >> + >> +unlock_out: >> + mutex_unlock(&vpfe_dev->lock); ; > >return -EIO? > Ok. >-- >Best regards, Klimov Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html