On Wed, May 27, 2009 at 9:00 AM, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> wrote: > Em Thu, 21 May 2009 22:26:35 -0400 > Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx> escreveu: > >> Hello Mauro, >> >> Please pull from http://kernellabs.com/hg/~dheitmueller/misc-fixes for >> the following: >> >> em28xx: don't create the audio device if no onboard audio processor > > I don't think that this patch is right. > > There are some devices that are equipped with non ac97 audio processors, for > example the ones with msp34xx. Those devices have digital audio. I'm not sure if > they work with em28xx-audio or with snd-usb-audio. So, the safest way is not to > deny the load of em28xx-audio. Mauro, The code does take into account devices that provide I2S audio. However, I think you may be correct that if I2S audio is configured, the driver will not load. I think I'm going to need to rework the patch a bit. The correct behavior should be that the em28xx-audio driver should only be loaded if vendor audio is required (either AC97 or I2S), and it appears that my logic didn't accomplish that [I confused an "if()" for an "else if()"]. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
