On Fri, May 1, 2009 at 11:17 PM, Frank Dischner <phaedrus961@xxxxxxxxxxxxxx> wrote: > Here's the updated patch with the requested changes. > > Frank Hello Frank, Sorry for taking so long to get back to this. I looked at the patch, and in particular, I compared the values programmed for QAM256 against the table you provided for QAM64. The delta is only four registers (210, 211, 323, 502). This isn't terribly surprising. A few questions: Do you have the USB trace you used as the basis for this dump? And did you programatically parse that dump to generate the table, or did you enter it by hand? Could you please email me the underlying dump so I can double check the data? I think the correct approach here would be to have three tables, a table of common registers, and two tables, one for each modulation type. It would program the common registers first, and then pick the correct table to program the rest. If we are concerned about the order that the registers are being programmed in, we can just setup the two tables so they start at the first register which is different (since it is almost at the bottom of the table anyway). That said, do you want to take a crack at the above suggested refactoring and resubmit an updated patch, or would you prefer to have me check in this patch as-is, and then refactor it myself afterward. It's up to you. Cheers, Devin -- Devin J. Heitmueller http://www.devinheitmueller.com AIM: devinheitmueller -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
