Hello Devin, On Tue, 31 Mar 2009 16:36:47 -0400 Devin Heitmueller <devin.heitmueller@xxxxxxxxx> wrote: > Hello Douglas, > > This patch looks pretty good. My only comment is to ask that you > please not mix large patches like this with whitespace changes in the > same changeset. It makes it much harder to review the patch when > functional changes are accompanied by stuff like this: > > - *vfd = *template; > - vfd->minor = -1; > - vfd->parent = &dev->udev->dev; > - vfd->release = video_device_release; > - vfd->debug = video_debug; > + > + *vfd = *template; > + vfd->minor = -1; > + vfd->v4l2_dev = &dev->v4l2_dev; > + vfd->release = video_device_release; > + vfd->debug = video_debug; > > - > -void em28xx_i2c_call_clients(struct em28xx *dev, unsigned int cmd, > void *arg); void em28xx_do_i2c_scan(struct em28xx *dev); > -int em28xx_i2c_register(struct em28xx *dev); > -int em28xx_i2c_unregister(struct em28xx *dev); > +int em28xx_i2c_register(struct em28xx *dev); > +int em28xx_i2c_unregister(struct em28xx *dev); > > Every instance of code like the above requires me to look at it > closely and make a determination whether the content *actually* > changed. > Ok, agreed. Thanks for reviewing! Cheers, Douglas -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
