On Tue, Mar 31, 2009 at 4:24 PM, Douglas Schilling Landgraf <dougsland@xxxxxxxxx> wrote: > Hello Mauro, > > Please pull from http://www.linuxtv.org/hg/~dougsland/em28xx for > the following: > > - em28xx: convert to v4l2_subdev > Thanks to Hans Verkuil <hverkuil@xxxxxxxxx> for helping this conversion. > > Boards tested: > > - WinTV HVR-900 > - PlayTV Box4 > - SIIG AVTuner-PVR > - Pixelview Prolink PlayTV USB 2.0 > - Hauppauge WinTV HVR 850 > - Pinnacle Dazzle DVC 90 > - Pinnacle Dazzle DVC 101 > - Pinnacle Dazzle DVC 107 > - Gadmei UTV310 > > Changes: > > # linux/drivers/media/video/em28xx/em28xx-cards.c | 143 > +++++++++++++++++++----- > # linux/drivers/media/video/em28xx/em28xx-core.c | 9 - > # linux/drivers/media/video/em28xx/em28xx-i2c.c | 72 ------------ > # linux/drivers/media/video/em28xx/em28xx-video.c | 78 ++++++------- > # linux/drivers/media/video/em28xx/em28xx.h | 10 + > > Thanks, > Douglas > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Hello Douglas, This patch looks pretty good. My only comment is to ask that you please not mix large patches like this with whitespace changes in the same changeset. It makes it much harder to review the patch when functional changes are accompanied by stuff like this: - *vfd = *template; - vfd->minor = -1; - vfd->parent = &dev->udev->dev; - vfd->release = video_device_release; - vfd->debug = video_debug; + + *vfd = *template; + vfd->minor = -1; + vfd->v4l2_dev = &dev->v4l2_dev; + vfd->release = video_device_release; + vfd->debug = video_debug; - -void em28xx_i2c_call_clients(struct em28xx *dev, unsigned int cmd, void *arg); void em28xx_do_i2c_scan(struct em28xx *dev); -int em28xx_i2c_register(struct em28xx *dev); -int em28xx_i2c_unregister(struct em28xx *dev); +int em28xx_i2c_register(struct em28xx *dev); +int em28xx_i2c_unregister(struct em28xx *dev); Every instance of code like the above requires me to look at it closely and make a determination whether the content *actually* changed. Thanks, Devin -- Devin J. Heitmueller http://www.devinheitmueller.com AIM: devinheitmueller -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
