Hi,
On Friday 27 March 2009 08:24:27 Hans Verkuil wrote:
> On Friday 27 March 2009 07:20:51 Kim, Heung Jun wrote:
> > Hello, Hans & everyone.
> >
> > I'm trying to adapt the various FOCUS MODE int the NEC ISP driver.
> > NEC ISP supports 4 focus mode, AUTO/MACRO/MANUAL/FULL or NORMAL.
> > but, i think that it's a little insufficient to use V4L2 FOCUS Feature.
> >
> > so, suggest that,
> >
> > - change V4L2_CID_FOCUS_AUTO's type from boolean to interger, and add
> > the following enumerations for CID values.
> >
> > enum v4l2_focus_mode {
> > V4L2_FOCUS_AUTO = 0,
> > V4L2_FOCUS_MACRO = 1,
> > V4L2_FOCUS_MANUAL = 2,
> > V4L2_FOCUS_NORMAL = 3,
> > V4L2_FOCUS_LASTP = 3,
> > };
> >
> > how about this usage? i wanna get some advice about FOCUS MODE.
V4L2_CID_FOCUS_AUTO is meant to change the auto-focus mode. Can you describe
FOCUS_MACRO and FOCUS_NORMAL in more details ? Are they auto-focus modes or
just focus presets ?
> This seems more logical to me:
>
> enum v4l2_focus_mode {
> V4L2_FOCUS_MANUAL = 0,
> V4L2_FOCUS_AUTO_NORMAL = 1,
> V4L2_FOCUS_AUTO_MACRO = 2,
> };
>
> At least this maps the current boolean values correctly. I'm not sure from
> your decription what the fourth auto focus mode is supposed to be.
Does an auto-macro focus mode really exists ?
> But I think it might be better to have a separate control that allows you
> to set the auto-focus mode. I can imagine that different devices might have
> different auto-focus modes.
>
> I've CC-ed Laurent since this is more his field than mine.
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
