Hans Verkuil wrote:
On Thursday 26 March 2009 03:34:53 Udo A. Steinberg wrote:
Mauro,
This patch allows users with multiple remotes to specify an RC5 address
for a remote from which key codes will be accepted. If no address is
specified, the default value of 0 accepts key codes from any remote. This
replaces the current hard-coded address checks, which are too
restrictive.
I think this should be reviewed by Steve Toth first (CC-ed him).
One thing that this patch breaks is if you have multiple Hauppauge remotes,
some sending 0x1e, some 0x1f. With this patch I can't use both, only one.
Hans, thanks for bringing this to my attention.
Mauro, This patch is a regression, although a small one. it probably
needs a little more work.
I too tend to have multiple remotes, I don't think it's that unusual for
long standing Hauppauge customers to have many boards with many types of
remotes.
It might be better to have an option to explicitly allow old Hauppauge
remotes that send 0x00.
I could live with this. It relegates older remotes but those remotes are
no longer made. This feels like a good compromise.
- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
