On Thu, 26 Mar 2009 11:22:26 +0200 vasaka@xxxxxxxxx wrote: > On Thu, Mar 26, 2009 at 10:34 AM, Mauro Carvalho Chehab > <mchehab@xxxxxxxxxxxxx> wrote: > > On Thu, 26 Mar 2009 01:19:08 +0200 > > vasaka@xxxxxxxxx wrote: > > > >> Hello, > >> > >> how should I format my post in order to patchwork tool understand > >> included patch correctly, > > > > If patchwork is not adding your patches there, then it means that the patches > > are broken (for example, line-wrapped), or that you're attaching it, and your > > emailer are using the wrong mime encoding type for diffs. > > > >> should I just format it like in v4l-dvb/README.patches described? > >> then how should I add additional comments to the mail which I do not > >> want to be in the patch log? > > > > All comments you add on your patch will be part of the commit message (except > > for the meta-tags, like from:). > > > >> It seems it is possible without special comment symbols. > > > > > > Cheers, > > Mauro > > > > can it be that patch made by > $diff -uprN v4l-dvb.orig v4l-dvb.my > patch.patch > and make commit in .my tree did not complain still broken? > > does gmail's web interface plain text mail composer has known issues, > which can interfere with sending patches? I never used a web interface to send patches. Since patches should be sent inline, and such interfaces do line wrapping, they aren't good for patch submission. Also, probably, they'll encode the attachments with text/plain or application/octet-stream, instead of the proper text/x-patch mime type. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html