On Friday 13 March 2009, chaithrika@xxxxxx wrote: > > +config DISPLAY_DAVINCI_DM646X_EVM > + tristate "DM646x EVM Video Display" > + depends on VIDEO_DEV && MACH_DAVINCI_DM646X_EVM > + select VIDEOBUF_DMA_CONTIG > + select VIDEO_DAVINCI_VPIF > + select VIDEO_ADV7343 > + select VIDEO_THS7303 A quick glance at the dm646x_display.c code in patch 7 suggests that the file name is generic, but the code is full of EVM-specific bits. I suggest either making the code generic (and maybe move most of that VPIF code into the VPIF driver) so other dm646x boards can reuse it ... or renaming it. Generic would IMO be preferrable. > +config VIDEO_DAVINCI_VPIF > + tristate "DaVinci VPIF Driver" > + depends on DISPLAY_DAVINCI_DM646X_EVM Please have the Kconfig helptext here explain what a VPIF is and does. Surely the driver is usable for any dm646x board, not just the EVM hardware; so, "depends on ARCH_DAVINCI_DM646x". And, patch style point, most of us like to see one patch adding an entire driver ... C source, headers, and its associated Kconfig and Kbuild support. Make sure that the kernel continues building between patches; in this case, the build will break after patch #5 since the source code it tries to build hasn't been added yet. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
