> On Thu, Mar 12, 2009 at 5:19 AM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: >> Hi Devin, >> >> Can you also do the last bit of the v4l2_device/subdev conversion by >> actually using the subdev callbacks (replace au0828_call_i2c_clients >> with >> v4l2_device_call_all), removing attach_inform and detach_inform (already >> deprecated in 2.6.29) and in au8522_decoder.c replacing >> v4l2-i2c-drv-legacy.h by v4l2-i2c-drv.h and removing the au8522_command. >> >> Basically, when you compile against 2.6.29 you shouldn't see any >> 'deprecated' warnings! >> >> I also suggest renaming au8522_decoder.c to just au8522.c, like all the >> other i2c modules. > > Hello Hans, > > I am certainly in favor of what you have proposed. However, I would > like to do it as an incremental improvement over what the series > currently contains. > > Any chance you can allow the current series to go in as-is, and I can > work on this over the next couple of days (as I will need to retest > everything)? The patch series has gotten kind of unwieldy. No problem. It's fairly trivial to do since you're 90% there already :-) Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html