Re: null pointer access in error path of lgdt3305 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 12, 2009 at 7:04 AM, Matthias Schwarzott <zzam@xxxxxxxxxx> wrote:
> Hi Michael!
>
> Looking at your new lgdt3305 driver, I noticed that the error path of
> lgdt3305_attach, that is also jumped to kzalloc errors, sets
> state->frontend.demodulator_priv to NULL.
>
> That will oops in case state is NULL. So you either need two goto labels for
> failures or just return in case kzalloc fails.

Patches welcomed. :-)

Regards,

David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux