> -----Original Message-----
> From: Aguirre Rodriguez, Sergio Alberto
> Sent: Monday, March 09, 2009 10:58 PM
> To: Alexey Klimov
> Cc: linux-media@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; Sakari Ailus;
> Tuukka.O Toivonen; Hiroshi DOYU; DongSoo(Nathaniel) Kim; MiaoStanley;
> Nagalla, Hari; Hiremath, Vaibhav; Lakhani, Amish; Menon, Nishanth
> Subject: RE: [PATCH 3/5] OV3640: Add driver
>
>
> > > + /* FIXME: QXGA framerate setting forced to 15 FPS */
> > > + if (isize == QXGA) {
<lots of i2c reg writes snip>
> > 4));
> > > + err = ov3640_write_reg(client, OV3640_ISP_YOUT_L,
> > > + (height_l -
> > 0x04));
> >
> > The same thing here.
>
> Agree, will fix..
I wonder if we cannot use an array and fill it up before pumping it out through i2c. something like:
struct configure_array{
u16 reg;
u16 val;
}
struct configure_array reg_config[]={
{OV3640_ISP_YOUT_H, 0x0},
...
};
Then
for (i=0;i< sizeof(reg_config)/sizeof(configure_array);i++) {
err = reg_write(reg_config[i].reg, reg_config[i].val);
if (err) {
/* do something */
}
}
Further, we have multiple sensors following CCI[1] - why not have a driver for the same, it will simplify the entire process - ov3640, mt9p012 both follow the spec at least.. dependency would be sensor -> cci dev->i2c framework.
Regards,
Nishanth Menon
Ref:
[1] MIPI CSI2 spec rev 1.0.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
