Guennadi Liakhovetski <g.liakhovetski@xxxxxx> writes:
> On Thu, 5 Mar 2009, Robert Jarzmik wrote:
>
>> The last buffer queued will often overrun, as the DMA chain
>> is finished, and the time the dma irq handler is activated,
>
> s/and the time/and during the time/ ?
If you wish, or might be simply "and before the dma irq handler is
activated". As you see fit.
>> + if (camera_status & overrun
>> + && !list_is_last(pcdev->capture.next, &pcdev->capture)) {
>> dev_dbg(pcdev->dev, "FIFO overrun! CISR: %x\n",
>> camera_status);
>> pxa_camera_stop_capture(pcdev);
>> pxa_camera_start_capture(pcdev);
>> goto out;
>> }
>> -
>> buf->active_dma &= ~act_dma;
>
> This empty like removal doesn't belong to the fix, I'll remove it when
> committing, and amend the commit message as above. Please, comment if you
> disagree.
I totally agree with you, remove that "removal" :)
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
