Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-notify

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday 09 March 2009 02:20:19 Trent Piepho wrote:
> On Sun, 8 Mar 2009, Hans Verkuil wrote:
> > - zoran/bt819: use new notify functionality.
>
> You put compat.h in the wrong spot in this patch.  It goes before any
> header file that are in v4l-dvb, but you've moved it to after
> v4l2-common.

That's not what README.patches says:

   There are several compatibility procedures already defined
   in "compat.h" file. If needed, it is better to include it after all
   other kernel standard headers, and before any specific header
   for that file. Something like:

        #include <linux/kernel.h>
        #include <linux/module.h>
                ...
        #include <linux/videodev2.h>
        #include <media/v4l2-common.h>

        #include "compat.h"

        #include "mydriver-header.h"

   should be included at the files under v4l-dvb tree. This header also
   includes linux/version.h.

Mauro, who's right?

Regards,

	Hans

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux