On Tue, 3 Mar 2009, Robert Jarzmik wrote: > Guennadi Liakhovetski <g.liakhovetski@xxxxxx> writes: > > > x = y > > | z; > > > > to > > > > x = y | > > z; > > > > just to make consistent with the rest of the driver. > May I do it the other way (change all other occurences) ? I was corrected on > other drivers to use the first form as the coding style, so can I reformat > pxa_camera to abide by this rule ? Emn, no. Just looked in CodingStyle - haven't found a word about it. So, I think, applies "keep consistent with the rest of the file." And, you know, someone might call this a matter of taste, but a line like x = y in a .c file looks unfinished to me, whereas x = y + clearly has a continuation. That's how I learned to break lines at school, at the Uni,... Ok, never mind, in any case, until this is not in CodingStyle, I will nak all attempts to convert the whole driver to the opposite of what it has ATM. So, I'll drop "3/4" and will request amendments to other affected patches, ok? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
