On Thu, 5 Mar 2009, Trent Piepho wrote: > On Thu, 5 Mar 2009, Robert Jarzmik wrote: > > Guennadi Liakhovetski <g.liakhovetski@xxxxxx> writes: > > > > > This is not a review yet - just an explanation why I was suggesting to > > > adjust height and width - you say yourself, that YUV422P (I think, this is > > > wat you meant, not just YUV422) requires planes to immediately follow one > > > another. But you have to align them on 8 byte boundary for DMA, so, you > > > violate the standard, right? If so, I would rather suggest to adjust width > > > and height for planar formats to comply to the standard. Or have I > > > misunderstood you? > > No, you understand perfectly. > > > > And now, what do we do : > > - adjust height ? > > - adjust height ? > > - adjust both ? > > > > I couldn't decide which one, any hint ? > > Shame the planes have to be contiguous. Software like ffmpeg doesn't > require this and could handle planes with gaps between them without > trouble. Plans aligned on 8 bytes boundaries would probably be faster in > fact. Be better if v4l2_buffer gave us offsets for each plane. > > If you must adjust, probably better to adjust both. Yes, adjusting both is also what I was suggesting in my original review. How about aligning the bigger of the two to 4 bytes and the smaller to 2? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
