Thanks, Vaibhav Hiremath > -----Original Message----- > From: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media- > owner@xxxxxxxxxxxxxxx] On Behalf Of Sakari Ailus > Sent: Tuesday, March 03, 2009 3:37 PM > To: linux-media@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx > Cc: Aguirre Rodriguez, Sergio Alberto; Toivonen Tuukka Olli Artturi; > Hiroshi DOYU; DongSoo Kim > Subject: [RFC 0/9] OMAP3 ISP and camera drivers > > Hi, > > So here's the patchset for OMAP 3 ISP and camera drivers plus the > associated V4L changes. Sergio Aguirre has been posting a related > patchset earlier, containing also sensor and lens driver used on > SDP. > This patchset is agains the linux-omap tree: > > <URL:http://www.muru.com/linux/omap/README_OMAP_GIT> > [Hiremath, Vaibhav] Sakari, Let me ask you basic question, have you tested/verified these patch-sets? The reason I am asking this question is, for me it was not working. I had to debug this and found that - - Changes missing in devices.c file, so isp_probe function will not be called at all, keeping omap3isp = NULL. You will end up into kernel crash in omap34xxcam_device_register. - The patches from Hiroshi DOYU doesn't build as is, you need to add one include line #include <linux/hardirq.h> in iovmmu.c (I am using the patches submitted on 16th Jan 2009) I have attached "git diff" output here with this mail for reference. Am I missing any patches here? I am not sure how Sergio is able to use these patches? If I am not missing anything, then I think you should mention all these issues clearly in the patch so that anybody who might want to use will not suffer. > So I and Sergio have synchronised our versions of the ISP and camera > drivers and this is the end result. There is still a lot of work to > do, > though. You can find some comments in individual patch descriptions. > If > the todo list for a patch is empty it doesn't mean there wouldn't be > anything left to do. ;) > > There's at least one major change to Sergio Aguirre's earlier > patches > which is that the ISP driver now uses the IOMMU from Hiroshi Doyu. > Hiroshi is away for some time now so there are just some hacks on > top of > Hiroshi's older iommu patches to use with current linux-omap. > > This patchset does not contain the resizer or preview wrappers from > TI > but they have been left intentionally out. A proper interface (V4L) > should be used for those and the camera driver should be somehow > involved --- the wrappers are just duplicating much of the camera > driver's functionality. > > I don't have any sensor or lens drivers to publish at this time. > > This patchset should work with the SDP and OMAPZoom boards although > you > need the associated sensor drivers + the board code from Sergio > Aguirre > to use it. You'll also need the IOMMU patchset from Hiroshi Doyu. > Everything except the sensor / board stuff is available here: > > <URL:http://www.gitorious.org/projects/omap3camera> > > In short, on linux-omap: > > $ git pull http://git.gitorious.org/omap3camera/mainline.git v4l \ > iommu omap3camera base > > Hiroshi's original iommu tree is here (branch iommu): > > <URL:http://git.gitorious.org/lk/mainline.git> > > Some of the camera and ISP driver development history is available, > too. > See the first link. > > Any feedback is appreciated. > > Sincerely, > > -- > Sakari Ailus > sakari.ailus@xxxxxxxxxxxxxxxxxxxxxxxxxx > > -- > To unsubscribe from this list: send the line "unsubscribe linux- > media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
isp_patch_fix.patch
Description: isp_patch_fix.patch
