Re: [PULL] http://linuxtv.org/hg/~awalls/cx18

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2009-02-26 at 22:25 -0300, Mauro Carvalho Chehab wrote:
> On Sat, 21 Feb 2009 21:22:22 -0500
> Andy Walls <awalls@xxxxxxxxx> wrote:

> > cx18: Change log lines for internal subdevs and fix tveeprom reads
> 
> +       strncpy(c.name, "cx18 tveeprom tmp", sizeof(c.name));
> +       c.name[sizeof(c.name)-1] = '\0';
> 
> Please use strlcpy() instead.

Sure.  I'm checking the change now.  I'll issue a pull request later
this weekend.


> > cx18: Convert the integrated A/V decoder core interface to a v4l2_subdev

> There were some merge conflicts. I've fixed it by hand, but I suspect that
> you'll need to properly tune the default values for v4l2_ctrl_query_fill().
> Please review my last patch and fix it accordingly with the limits of each
> V4L2_CID.

Sorry I didn't get to this sooner (I was traveling).
I see you've already fixed the values.  Your fixes are as Hans had
intended them for cx18.

Thanks.

Regards,
Andy

> Cheers,
> Mauro


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux