Alle lunedì 09 febbraio 2009, hai scritto: > On Mon, 9 Feb 2009 17:50:44 +0100 > Nicola Soranzo <nsoranzo@xxxxxxxxxx> wrote: > > Lots of codign style fixes and a typo correction for em28xx. > > > > Priority: low > > > > Signed-off-by: Nicola Soranzo <nsoranzo@xxxxxxxxxx> > > > > --- > > diff -r 71e5a36634ea linux/drivers/media/video/em28xx/em28xx-audio.c > > --- a/linux/drivers/media/video/em28xx/em28xx-audio.c Mon Feb 02 10:33:31 > > 2009 +0100 > > +++ b/linux/drivers/media/video/em28xx/em28xx-audio.c Mon Feb 09 12:47:13 > > 2009 +0100 > > @@ -264,8 +264,7 @@ > > } > > > > #if LINUX_VERSION_CODE <= KERNEL_VERSION(2, 6, 16) > > -static int snd_pcm_alloc_vmalloc_buffer(snd_pcm_substream_t *subs, > > - size_t size) > > +static int snd_pcm_alloc_vmalloc_buffer(snd_pcm_substream_t *subs, > > size_t size) > > Please, prefer, instead, something like: > +static int snd_pcm_alloc_vmalloc_buffer(snd_pcm_substream_t *subs, > size_t size) This part was line wrapped by KMail (I've changed its setting as suggested), the original was: diff -r 9cb19f080660 linux/drivers/media/video/em28xx/em28xx-audio.c --- a/linux/drivers/media/video/em28xx/em28xx-audio.c Tue Feb 10 05:26:05 2009 -0200 +++ b/linux/drivers/media/video/em28xx/em28xx-audio.c Tue Feb 10 20:33:23 2009 +0100 @@ -264,8 +264,7 @@ static int em28xx_cmd(struct em28xx *dev } #if LINUX_VERSION_CODE <= KERNEL_VERSION(2, 6, 16) -static int snd_pcm_alloc_vmalloc_buffer(snd_pcm_substream_t *subs, - size_t size) +static int snd_pcm_alloc_vmalloc_buffer(snd_pcm_substream_t *subs, size_t size) #else static int snd_pcm_alloc_vmalloc_buffer(struct snd_pcm_substream *subs, size_t size) The function definition is <= 80 characters, so I've put it on one line. Do you anyway prefer the second parameter on the other line for consistency? Thanks for the review, I've fixed all other required changes and I will send the new version later. Nicola -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
