On Thu, 5 Feb 2009 10:57:21 -0800 (PST) Trent Piepho <xyzzy@xxxxxxxxxxxxx> wrote: > Mauro, > > Please pull from http://linuxtv.org/hg/~tap/v4l-dvb > > for the following 3 changesets: > > 01/03: cx88: Fix MPEG kconfig dependencies > http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=2e05fd69e6b6 Hmm... This patch converts a depends on into a select. This is not nice, since select is known to not be properly handled by kernel build system. Also, the kbuild maintainer recommended us to use select only for options that doesn't have any dependency. This is reflected on Kbuild docs: Note: select should be used with care. select will force a symbol to a value without visiting the dependencies. By abusing select you are able to select a symbol FOO even if FOO depends on BAR that is not set. In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies. That will limit the usefulness but on the other hand avoid the illegal configurations all over. kconfig should one day warn about such things. So, IMO, we should solve the issue using a different logic that relies only on depends on. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
