Re: [PULL] gspca

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 5 Feb 2009 10:32:31 +0100
Jean-Francois Moine <moinejf@xxxxxxx> wrote:

> Hi Mauro,
> 
> The changes relative to 'gspca - main' should go to the kernel 2.6.29.
> 
> Please pull from http://linuxtv.org/hg/~jfrancois/gspca/
> for:
> 
> changeset:   10433:fd2cb3b7916e
> gspca - vc032x: Remove the vc0321 reset.
> 
> changeset:   10434:3f4a7bc53d8e
> gspca - some drivers: Fix compilation warnings.
> 
> changeset:   10435:4d0827823ebc
> gspca - main: Don't kill the URBs when the device is disconnected.
> 
> changeset:   10436:2dd691c92f20
> gspca - main: Destroy the URBs at disconnection time.
> 
> changeset:   10437:f9e9cf9bfbf4
> gspca - main: More checks of the device disconnection.
> 
> changeset:   10438:949a12648c68
> gspca - main: Better handling of disconnection at the API.

Hmm... it seems that your tree has more changesets than what you've pointed on
your pull request... I got here 15 patches.

On the last changesets, I've seen that you're adding a lot of private controls, like those:

+#define V4L2_CID_IMAGE_QUALITY (V4L2_CID_PRIVATE_BASE + 0)
+#define V4L2_CID_CAM_QUALITY (V4L2_CID_PRIVATE_BASE + 1)

and, on other driver:

+#define V4L2_CID_INFRARED (V4L2_CID_PRIVATE_BASE + 0)
+#define V4L2_CID_IMAGE_QUALITY (V4L2_CID_PRIVATE_BASE + 1)
+#define V4L2_CID_JPEG_QUALITY (V4L2_CID_PRIVATE_BASE + 2)

We should really standardize those controls and prepare some patches for V4L2
API also, documenting what does that mean. Btw, it as not clear what's the
difference between those "quality" controls...

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux