Re: [PATCH] newport: newport_*wait() return 0 on timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Roel,

It seems that you've sent this driver to the wrong ML. Video adapters are not handled on those ML's.

On Sat, 31 Jan 2009 16:29:39 +0100
Roel Kluin <roel.kluin@xxxxxxxxx> wrote:

> With a postfix decrement t reaches -1 on timeout which results in a
> return of 0.
> 
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
> diff --git a/include/video/newport.h b/include/video/newport.h
> index 1f5ebea..001b935 100644
> --- a/include/video/newport.h
> +++ b/include/video/newport.h
> @@ -453,7 +453,7 @@ static __inline__ int newport_wait(struct newport_regs *regs)
>  {
>  	int t = BUSY_TIMEOUT;
>  
> -	while (t--)
> +	while (--t)
>  		if (!(regs->cset.status & NPORT_STAT_GBUSY))
>  			break;
>  	return !t;
> @@ -463,7 +463,7 @@ static __inline__ int newport_bfwait(struct newport_regs *regs)
>  {
>  	int t = BUSY_TIMEOUT;
>  
> -	while (t--)
> +	while (--t)
>  		if(!(regs->cset.status & NPORT_STAT_BBUSY))
>  			break;
>  	return !t;




Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux